[PP-1507] Present sorts as links with palaceproject.io namespaced sort rels. #2100
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
=======================================
Coverage 90.72% 90.72%
=======================================
Files 351 351
Lines 40878 40901 +23
Branches 8853 8857 +4
=======================================
+ Hits 37085 37109 +24
+ Misses 2486 2484 -2
- Partials 1307 1308 +1 ☔ View full report in Codecov by Sentry. |
dbernstein
force-pushed
the
PP-1507-do-not-present-sorts-as-facets
branch
from
16a3dbe to
de43c6e
Compare
There was a problem hiding this comment.
- the new terms and how they appear in the feed: is this what the clients would find useful?
I think this question is probably better directed to @io7m and @mauricecarrier7, since they are the ones that will need to use this to implement the new facet design using these feeds. It would probably help them to have some examples of what the feed will look like after these changes.
- should I be refactoring the FeedData class to remove the "Sort by" facet group all together? Or should we do that as a later revision once the client apps start using OPDS2?
It does seem like a deeper refactor would make things clearer here. The code is referring to order facets, but with this change we are updating these to be sorts rather then facets.
I'm happy to defer to you if we tackle this now, or if we do this refactoring later once the client apps have this implemented.
|
@mauricecarrier7 and @io7m : I've updated the description above to include what you can expect to see in the revised feed re new sorting links. Let me know if the approach I took is going to work for you on the client end. An of course if you'd like me to change anything, don't hold back. |
|
I can't see any obvious reason why this would be a problem. |
|
Same, looks good to me. I'm not clear on the extent of what will need to change when we move to OPDS2, but holding on major refactoring until then sounds like a good approach. |
dbernstein
changed the title
dbernstein
force-pushed
the
PP-1507-do-not-present-sorts-as-facets
branch
from
dd3a3c2 to
0f01ae1
Compare
|
I created a follow on ticket to refactor when we remove sorting facets altogether. |
dbernstein
force-pushed
the
PP-1507-do-not-present-sorts-as-facets
branch
from
0f01ae1 to
3c6969d
Compare
Description
This is a first pass at the ticket below:
I added two new elements to the terms namespace.
Then I implemented them here for the OPDS 1 feed and OPDS 2 feeds.
I'm adding in new links for sorts based on the new namespace terms while leaving the current approach with facets in place for backward compatibility.
The OPDS2 feed adds a new sort link and removes the old "Sort by" facet group since as far as I know, no one is using the OPDS2 feed.
The new sort links will appear just below the root. The old sorting links formatted using the facet groups will remain in place until we we're ready to remove them. You can expect something like the following:
I'm not sure if this is the right approach or whether it would be cleaner to do a more extensive refactor.
I'd like feedback on 1) the new terms and how they appear in the feed: is this what the clients would find useful? 2) should I be refactoring the FeedData class to remove the "Sort by" facet group all together? Or should we do that as a later revision once the client apps start using OPDS2?
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1507
How Has This Been Tested?
Checklist